qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] block/rbd: Remove unused local variable


From: Stefan Weil
Subject: [Qemu-devel] [PATCH] block/rbd: Remove unused local variable
Date: Sat, 7 May 2011 22:15:57 +0200

cppcheck report:
rbd.c:246: style: Variable 'snap' is assigned a value that is never used

Remove snap and the related code.

Cc: Christian Brunner <address@hidden>
Cc: Kevin Wolf <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
---
 block/rbd.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/block/rbd.c b/block/rbd.c
index 249a590..5c7d44e 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -524,7 +524,6 @@ static int rbd_open(BlockDriverState *bs, const char 
*filename, int flags)
     RbdHeader1 *header;
     char pool[RBD_MAX_SEG_NAME_SIZE];
     char snap_buf[RBD_MAX_SEG_NAME_SIZE];
-    char *snap = NULL;
     char *hbuf = NULL;
     int r;
 
@@ -533,9 +532,6 @@ static int rbd_open(BlockDriverState *bs, const char 
*filename, int flags)
                       s->name, sizeof(s->name)) < 0) {
         return -EINVAL;
     }
-    if (snap_buf[0] != '\0') {
-        snap = snap_buf;
-    }
 
     if ((r = rados_initialize(0, NULL)) < 0) {
         error_report("error initializing");
-- 
1.7.2.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]