[Qemu-devel] [PATCH] linux-user: Set uninitialized local variable and disable unused code

[Stefan Weil]

cppcheck report:
linux-user/signal.c:2057: error: Uninitialized variable: err

cppcheck is correct. Setting err = 0 is a workaround to avoid
random results and the cppcheck warning.

Function restore_fpu_state is currently unused, so I disabled the code.

Signed-off-by: Stefan Weil <address@hidden>
---
 linux-user/signal.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/linux-user/signal.c b/linux-user/signal.c
index ce033e9..4bda475 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -2027,6 +2027,8 @@ sigsegv:
         unlock_user(sf, sf_addr, sizeof(struct target_signal_frame));
        force_sig(TARGET_SIGSEGV);
 }
+
+#if 0 /* TODO: function is unused */
 static inline int
 restore_fpu_state(CPUState *env, qemu_siginfo_fpu_t *fpu)
 {
@@ -2053,6 +2055,8 @@ restore_fpu_state(CPUState *env, qemu_siginfo_fpu_t *fpu)
         /* XXX: incorrect */
         err = __copy_from_user(&env->fpr[0], &fpu->si_float_regs[0],
                                     (sizeof(unsigned long) * 32));
+#else
+        err = 0;
 #endif
         err |= __get_user(env->fsr, &fpu->si_fsr);
 #if 0
@@ -2065,7 +2069,7 @@ restore_fpu_state(CPUState *env, qemu_siginfo_fpu_t *fpu)
 #endif
         return err;
 }
-
+#endif
 
 static void setup_rt_frame(int sig, struct target_sigaction *ka,
                            target_siginfo_t *info,
-- 
1.7.2.5