qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] usb-linux: Add missing break statement


From: Hans de Goede
Subject: Re: [Qemu-devel] [PATCH] usb-linux: Add missing break statement
Date: Sun, 08 May 2011 10:31:23 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Lightning/1.0b2 Thunderbird/3.1.10

Thanks, good catch.

Acked-by: Hans de Goede <address@hidden>

On 05/07/2011 10:10 PM, Stefan Weil wrote:
cppcheck report:
usb-linux.c:661: warning: Redundant assignment of "len" in switch

Please check whether adding a break statement
is the correct solution for this warning.

Cc: Hans de Goede<address@hidden>
Cc: Gerd Hoffmann<address@hidden>
Signed-off-by: Stefan Weil<address@hidden>
---
  usb-linux.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/usb-linux.c b/usb-linux.c
index 36a01ea..0ef1d26 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -659,6 +659,7 @@ static int usb_host_handle_iso_data(USBHostDevice *s, 
USBPacket *p, int in)
                          switch(errno) {
                          case ETIMEDOUT:
                              len = USB_RET_NAK;
+                            break;
                          case EPIPE:
                          default:
                              len = USB_RET_STALL;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]