[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] ide: Split qdev "ide-drive" into "ide-hd
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd" |
Date: |
Tue, 10 May 2011 10:14:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
> Hi,
>
>> +#define DEFINE_IDE_DEV_PROPERTIES() \
>> + DEFINE_PROP_UINT32("unit", IDEDrive, dev.unit, -1), \
>> + DEFINE_BLOCK_PROPERTIES(IDEDrive, dev.conf), \
>> + DEFINE_PROP_STRING("ver", IDEDrive, dev.version), \
>> + DEFINE_PROP_STRING("serial", IDEDrive, dev.serial)
>
> This can also be done this way:
>
> static Property ide_properties[] = {
> DEFINE_PROP_UINT32("unit", IDEDrive, dev.unit, -1),
> [ ... ]
> DEFINE_PROP_END_OF_LIST(),
> };
>
>> +static IDEDeviceInfo ide_dev_info[] = {
>> + {
>> + .qdev.name = "ide-hd",
>> + .qdev.fw_name = "drive",
>> + .qdev.desc = "virtual IDE disk",
>> + .qdev.size = sizeof(IDEDrive),
>> + .init = ide_hd_initfn,
>
> .qdev.props = ide_properties,
>
> Works only as long as all devices have exactly the same set (i.e. for
> scsi it wouldn't work as not all devices have the "removable"
> property).
>
> I tend to like this more than the #define. YMMV, matter of taste.
In general, I prefer shared variables rather to duplication via #define,
too. But in this case, I went with #define anyway, so we don't have to
change from variable to #define when a device-specific property comes
along, and for consistency with scsi-disk.c (whatever that's worth).
- [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more, Markus Armbruster, 2011/05/09
- [Qemu-devel] [PATCH v2 3/5] block QMP: Drop query-block member "type" (type= in info block), Markus Armbruster, 2011/05/09
- [Qemu-devel] [PATCH v2 5/5] block: Remove type hint, it's guest matter, doesn't belong here, Markus Armbruster, 2011/05/09
- [Qemu-devel] [PATCH v2 4/5] blockdev: Store -drive option media in DriveInfo, Markus Armbruster, 2011/05/09
- [Qemu-devel] [PATCH v2 2/5] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd", Markus Armbruster, 2011/05/09
- [Qemu-devel] [PATCH v2 1/5] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd", Markus Armbruster, 2011/05/09
- Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more, Gerd Hoffmann, 2011/05/09
- Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more, Kevin Wolf, 2011/05/10
- [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 4/6] blockdev: Store -drive option media in DriveInfo, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 5/6] block: Remove type hint, it's guest matter, doesn't belong here, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 6/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block), Markus Armbruster, 2011/05/12