Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more

[Kevin Wolf]

Am 09.05.2011 11:51, schrieb Markus Armbruster:
> This patch series is about purging the "type hint" from the block
> layer.  My previous series cleaned up improper uses it.  Remaining
> uses are info block and qdevs ide-drive, scsi-disk.
> 
> ide-drive and scsi-disk can either act as disk or as CD drive.  They
> use their drive's type hint to decide between disk and CD.  This is
> unclean.  Disk vs. CD needs to be in qdev, not BlockDriverState,
> because it belongs to the drive's guest part.
> 
> Split them into separate devices for disk and CD.  Keep the old ones
> for backward compatibility.
> 
> Remove the type hint from info block.  Its value is unreliable anyway.
> libvirt doesn't use it.
> 
> I posted v1 quite some time ago.  Since we were working towards a
> release then, we decided to take only the bonus bug fixes (PATCH 1-3),
> and revisit the rest later.  Which has turned out to be "somewhat"
> later than anticpiated.  Sorry about that.

Thanks, applied to the block branch.

Kevin