Re: [Qemu-devel] [PULL v2] eepro100: Update of patch series (fixes and enhancements)

[Michael S. Tsirkin]

On Sat, Apr 30, 2011 at 10:40:03PM +0200, Stefan Weil wrote:
> Hi,
> 
> this is the second version of a series of patches for eepro100 which mainly
> fix endianness issues and enhance register access. There was a bug report
> on qemu-devel recently which is fixed by these enhancements, see
> http://lists.nongnu.org/archive/html/qemu-devel/2011-03/msg02109.html.
> 
> Changes in v2:
> 
> * The 2nd patch is new.
> 
> * Patches are sorted in a different order. The first 4 patches and the
>   rest are independent, so it's possible to apply parts of the series.
> 
> * The endianness patch was updated to address the feedback which I received.
>   I still use local functions to access physical memory - mainly because
>   I want to use cpu_physical_memory_read / cpu_physical_memory_write as long
>   as I am not sure whether the alignment requirements for the suggested
>   open coded variant are met.
>   The prefix is e100 - shorter and more up-to-date than eepro100.
>   When I started this device emulation, linux still used a module called
>   eepro100. Today, the only linux module is called e100. So my final goal
>   is renaming all eepro100 to e100.

We still have e1000 and it might be a bit confusing for the device
name/file name. So I'm not sure 100%. Pls do keep an alias at least.
But short function names are surely good.

> I did not change the patch which adds padding to short received frames,
> because I'd like to keep the preprocessor statement 
> (CONFIG_PAD_RECEIVED_FRAMES)
> as some kind of documentation (even if QEMU's network code won't be modified
> in the near future to fully support a real ethernet emulation).
> 
> Kind regards,
> 
> Stefan W.
> 
> 
> 
> The following changes since commit 08ab2ccb08372a52ee1c597acf640cadb9089a3a:
> 
>   Merge branch 'patches' of git://qemu.weilnetz.de/git/qemu (2011-04-29 
> 20:01:51 +0000)
> 
> are available in the git repository at:
> 
>   git://qemu.weilnetz.de/git/qemu.git patches
> 
> Stefan Weil (10):
>       eepro100: Avoid duplicate debug messages
>       eepro100: Remove type casts which are no longer needed
>       eepro100: Remove unused structure element
>       eepro100: Pad received short frames
>       eepro100: Fix endianness issues
>       eepro100: Support byte/word writes to port address
>       eepro100: Support byte/word writes to pointer register
>       eepro100: Support byte/word read/write access to MDI control register
>       eepro100: Support byte read access to general control register
>       eepro100: Support 32 bit read/write access to flash register
> 
>  hw/eepro100.c |  298 
> +++++++++++++++++++++++++++++++++++++++++----------------
>  1 files changed, 217 insertions(+), 81 deletions(-)