[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/11] target-mips/gdbstub: remove old CONFIG_SO
|
From: |
Aurelien Jarno |
|
Subject: |
Re: [Qemu-devel] [PATCH 02/11] target-mips/gdbstub: remove old CONFIG_SOFTFLOAT #ifdef |
|
Date: |
Sun, 15 May 2011 17:46:38 +0200 |
|
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Sun, May 15, 2011 at 03:29:21PM +0100, Peter Maydell wrote:
> On 15 May 2011 15:13, Aurelien Jarno <address@hidden> wrote:
> > target-mips has been switched to softfloat only long ago, but a
> > few #ifdef CONFIG_SOFTFLOAT have been forgotten. Remove them.
>
> > -#ifndef CONFIG_SOFTFLOAT
> > /* no floating point exception for native float */
> > SET_FP_ENABLE(env->active_fpu.fcr31, 0);
> > -#endif
>
> Shouldn't the whole of this section be removed? This is
> an #ifndef, not a #ifdef...
>
Yes good catch, it's a mistake from my side. I have fixed it locally,
I'll send it at the same time of the next version of the series.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH 04/11] softfloat: always enable floatx80 and float128 support, (continued)
- [Qemu-devel] [PATCH 02/11] target-mips/gdbstub: remove old CONFIG_SOFTFLOAT #ifdef, Aurelien Jarno, 2011/05/15
- [Qemu-devel] [PATCH 10/11] softfloat: add floatx80_log2() function, Aurelien Jarno, 2011/05/15
- [Qemu-devel] [PATCH 05/11] target-i386: remove old code handling float64, Aurelien Jarno, 2011/05/15
- [Qemu-devel] [PATCH 09/11] target-i386: add support for FPU exceptions, Aurelien Jarno, 2011/05/15
- [Qemu-devel] [PATCH 03/11] softfloat-native: remove, Aurelien Jarno, 2011/05/15