Re: [Qemu-devel] Add option to disable Cocoa on Mac OS X

[Ben Leslie]

On Wed, May 11, 2011 at 23:54, Peter Maydell <address@hidden> wrote:
> On 7 May 2011 12:40, Alexander Graf <address@hidden> wrote:
>> So I suppose the only thing missing is a --disable-cocoa option, yup.
>
> I've just noticed that some of the code in block/raw-posix.c
> uses the CONFIG_COCOA #define to gate whether to do MacOSX
> specific handling of CDROMs and so on. I'm not a MacOS expert
> but maybe that needs to be changed to some other ifdef -- I'm
> guessing we don't want to have cdrom handling randomly change
> behaviour just because the user tried to disable Cocoa graphics
> handling...

These seems to be a good point. Potentially checking for __APPLE__ and
__MACH__ makes more sense? (See: http://predef.sourceforge.net/preos.html#sec20)

Cheers,

Ben