[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter
From: |
David Ahern |
Subject: |
Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter |
Date: |
Tue, 17 May 2011 11:00:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110421 Fedora/3.1.9-2.fc14 Thunderbird/3.1.9 |
On 05/17/11 01:20, Gerd Hoffmann wrote:
>> On 05/16/11 13:56, Gerd Hoffmann wrote:
>>> This patch finally merges the EHCI host adapter aka USB 2.0 support.
>>>
>>> Based on git://git.kiszka.org/qemu.git ehci
>>>
>>> Changes:
>>> - Adapt to recent changes in the usb subsystem.
>>> - Don't create device automagically, use -device instead.
>>> - Add quickstart text file, see docs/usb2.txt.
>>> - A bunch of codestyle fixups.
>>> - Add authors+contributers list.
>>> - Zap EHCI_NOMICROFRAMES, qemu can't handle a 8 kHz
>>> wakeup rate anyway.
>>> - A few bug fixes.
>>>
>>> Signed-off-by: Gerd Hoffmann<address@hidden>
>>
>> As someone who spent a significant amount of time working on the EHCI
>> code last year I am absolutely not ok with this. The entire contribution
>> history for EHCI lost - and for no reason.
>
> There is a reason. I've tried to keep the history, but it was a big
> mess with conflicts and build errors due to ehci being out-of-tree for a
> loooooong time.
>
>> The inclusion of EHCI into
>> qemu can be done in such a way as to maintain the history.
>
> Prove it. Give me a git tree with ehci history I can use as replacement
> for patch 18 and I'll pull it in.
To come back to this one: Back in December when you got a hankering to
to be the USB maintainer Jan could have created a pull request that you
sucked into your repo. I am not a git guru, but I believe the syntax is
something like:
git request-pull master git://git.kiszka.org/qemu.git
At this point you clearly have no motivation or intention to save the
history. The least you can do is summarize it with a better commit
message. One that references the original code and the efforts by Mark
Burkley. I believe this is the original code:
http://lists.gnu.org/archive/html/qemu-devel/2008-10/msg00764.html
Followed by contributions by various folks and my efforts to make the
code usable - validated by the fact that for a linux host USB storage
devices worked (mostly) as well as printers and scanners. There are
about 16 commits to usb-ehci; surely that is not too cumbersome to read
the commit logs and properly summarize.
David
>
> cheers,
> Gerd
>
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, (continued)
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, David Ahern, 2011/05/17
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, Gerd Hoffmann, 2011/05/17
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, David Ahern, 2011/05/17
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, Hans de Goede, 2011/05/17
- [Qemu-devel] USB streaming [Re: [PATCH 18/18] usb: add ehci adapter], David Ahern, 2011/05/17
- Re: [Qemu-devel] USB streaming [Re: [PATCH 18/18] usb: add ehci adapter], Hans de Goede, 2011/05/17
- Re: [Qemu-devel] USB streaming [Re: [PATCH 18/18] usb: add ehci adapter], David Ahern, 2011/05/17
- Re: [Qemu-devel] USB streaming [Re: [PATCH 18/18] usb: add ehci adapter], David Ahern, 2011/05/17
- Re: [Qemu-devel] USB streaming [Re: [PATCH 18/18] usb: add ehci adapter], Hans de Goede, 2011/05/18
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, Hans de Goede, 2011/05/17
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter,
David Ahern <=
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, Blue Swirl, 2011/05/17
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, David Ahern, 2011/05/17
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, Andreas Färber, 2011/05/21
Re: [Qemu-devel] [PATCH 00/18] usb patch queue: add usb 2.0, Anthony Liguori, 2011/05/16