[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [V2 24/25] [virtio-9p] clean up v9fs_remove.
From: |
Venkateswararao Jujjuri (JV) |
Subject: |
[Qemu-devel] [V2 24/25] [virtio-9p] clean up v9fs_remove. |
Date: |
Tue, 17 May 2011 12:43:50 -0700 |
Rearrange the code so that we can avoid V9fsRemoveState
and additional malloc()s.
Signed-off-by: Venkateswararao Jujjuri "<address@hidden>
---
hw/9pfs/virtio-9p.c | 25 ++++++++++---------------
hw/9pfs/virtio-9p.h | 6 ------
2 files changed, 10 insertions(+), 21 deletions(-)
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index a79ec72..ce45f00 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -2579,35 +2579,30 @@ out:
static void v9fs_remove(void *opaque)
{
- V9fsPDU *pdu = opaque;
- V9fsState *s = pdu->s;
int32_t fid;
- V9fsRemoveState *vs;
int err = 0;
+ size_t offset = 7;
+ V9fsFidState *fidp;
+ V9fsPDU *pdu = opaque;
- vs = qemu_malloc(sizeof(*vs));
- vs->pdu = pdu;
- vs->offset = 7;
-
- pdu_unmarshal(vs->pdu, vs->offset, "d", &fid);
+ pdu_unmarshal(pdu, offset, "d", &fid);
- vs->fidp = lookup_fid(s, fid);
- if (vs->fidp == NULL) {
+ fidp = lookup_fid(pdu->s, fid);
+ if (fidp == NULL) {
err = -EINVAL;
goto out;
}
- err = v9fs_do_remove(s, &vs->fidp->path);
+ err = v9fs_do_remove(pdu->s, &fidp->path);
if (err < 0) {
err = -errno;
} else {
- err = vs->offset;
+ err = offset;
}
/* For TREMOVE we need to clunk the fid even on failed remove */
- free_fid(s, vs->fidp->fid);
+ free_fid(pdu->s, fidp->fid);
out:
- complete_pdu(s, pdu, err);
- qemu_free(vs);
+ complete_pdu(pdu->s, pdu, err);
}
static void v9fs_wstat_post_truncate(V9fsState *s, V9fsWstatState *vs, int err)
diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h
index ffbb3b8..b693f74 100644
--- a/hw/9pfs/virtio-9p.h
+++ b/hw/9pfs/virtio-9p.h
@@ -333,12 +333,6 @@ typedef struct V9fsWriteState {
int cnt;
} V9fsWriteState;
-typedef struct V9fsRemoveState {
- V9fsPDU *pdu;
- size_t offset;
- V9fsFidState *fidp;
-} V9fsRemoveState;
-
typedef struct V9fsWstatState
{
V9fsPDU *pdu;
--
1.7.1
- Re: [Qemu-devel] [V2 06/25] [virtio-9p] coroutines for readlink, (continued)
- [Qemu-devel] [V2 02/25] [virtio-9p] Change all pdu handlers to coroutines., Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 17/25] hw/9pfs: Add yield support to xattr related coroutine, Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 22/25] [virtio-9p] coroutine and threading for mkdir, Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 21/25] hw/9pfs: Update v9fs_mknod to use coroutines, Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 04/25] [virtio-9p] clean up v9fs_readlink., Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 23/25] [virtio-9p] Remove post functions for v9fs_remove, Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 20/25] hw/9pfs: Add yield support to mknod coroutine, Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 01/25] [virtio-9p] Add infrastructure to support glib threads and coroutines., Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 25/25] [virtio-9p] coroutine and threading for remove/unlink, Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 24/25] [virtio-9p] clean up v9fs_remove.,
Venkateswararao Jujjuri (JV) <=
- Re: [Qemu-devel] [V2 0/25] Async threading for VirtFS using glib threads & coroutines., Stefan Hajnoczi, 2011/05/18