[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization |
Date: |
Wed, 18 May 2011 08:57:11 +0100 |
On Wed, May 18, 2011 at 7:55 AM, Dmitry Konishchev <address@hidden> wrote:
> So, if you are agreed with the said above, you can accept this patch
> and then I'll write an enchancement for it with bdrv_is_allocated()
> because it is going to include this patch.
Yes, optimizing is_not_zero() is good. The only additional thing I
suggest is adding a comment before the function to document the length
constraint.
Kevin Wolf is CCed, he's the QEMU block layer maintainer and may have
additional thoughts before accepting this patch.
Stefan
- [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization, Dmitry Konishchev, 2011/05/17
- Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization, Stefan Hajnoczi, 2011/05/17
- Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization, Dmitry Konishchev, 2011/05/18
- Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization, Kevin Wolf, 2011/05/18
- Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization, Dmitry Konishchev, 2011/05/18
- Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization, Kevin Wolf, 2011/05/18
- Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization, Dmitry Konishchev, 2011/05/18
- [Qemu-devel] [PATCH] is_not_zero() optimization in qemu-img, Dmitry Konishchev, 2011/05/18
- Re: [Qemu-devel] [PATCH] is_not_zero() optimization in qemu-img, Kevin Wolf, 2011/05/18
- Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization, Peter Maydell, 2011/05/18
- Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization, Peter Maydell, 2011/05/18
- Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization, Dmitry Konishchev, 2011/05/18