[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/6] defaults: ide-cd and scsi-cd devices sup
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM |
Date: |
Wed, 18 May 2011 18:30:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 16.05.2011 15:04, schrieb Markus Armbruster:
>> ide-hd does *not* suppress the default CD-ROM, unlike legacy
>> ide-drive.
>>
>> scsi-cd *does* suppress it, unlike legacy scsi-disk.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> vl.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index bffba69..e271c0b 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -279,7 +279,9 @@ static struct {
>> { .driver = "isa-serial", .flag = &default_serial },
>> { .driver = "isa-parallel", .flag = &default_parallel },
>> { .driver = "isa-fdc", .flag = &default_floppy },
>> + { .driver = "ide-cd", .flag = &default_cdrom },
>> { .driver = "ide-drive", .flag = &default_cdrom },
>> + { .driver = "scsi-cd", .flag = &default_cdrom },
>> { .driver = "virtio-serial-pci", .flag = &default_virtcon },
>> { .driver = "virtio-serial-s390", .flag = &default_virtcon },
>> { .driver = "virtio-serial", .flag = &default_virtcon },
>
> Wow, I wasn't even aware that we have such magic in relatively new code
> like -device. And that it's only effective for -device, but not -drive.
> And to be honest, I really never wanted to know...
Believe me, I don't like this either.
> Anyway, you can't create an ide-hd on secondary master now because there
> is the default CD-ROM already:
>
> qemu-system-x86_64: -device ide-hd,drive=blubb,unit=0,bus=ide.1: IDE
> unit 0 is in use
> qemu-system-x86_64: -device ide-hd,drive=blubb,unit=0,bus=ide.1: Device
> 'ide-hd' could not be initialized
Meh. I'll go back to letting any IDE device disable the default CD-ROM.
- [Qemu-devel] [PATCH v4 0/6] Split ide-drive and scsi-disk qdevs, and more, Markus Armbruster, 2011/05/16
- [Qemu-devel] [PATCH v4 6/6] block: Remove type hint, it's guest matter, doesn't belong here, Markus Armbruster, 2011/05/16
- [Qemu-devel] [PATCH v4 3/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM, Markus Armbruster, 2011/05/16
- [Qemu-devel] [PATCH v4 4/6] block QMP: Deprecate query-block's "type", drop info block's "type=", Markus Armbruster, 2011/05/16
- [Qemu-devel] [PATCH v4 5/6] blockdev: Store -drive option media in DriveInfo, Markus Armbruster, 2011/05/16
- [Qemu-devel] [PATCH v4 1/6] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd", Markus Armbruster, 2011/05/16
- [Qemu-devel] [PATCH v4 2/6] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd", Markus Armbruster, 2011/05/16