qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any virtio-serial


From: Amit Shah
Subject: Re: [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any virtio-serial-bus device must have into bus props
Date: Thu, 19 May 2011 18:41:31 +0530
User-agent: Mutt/1.5.21 (2010-09-15)

On (Thu) 19 May 2011 [13:37:16], Markus Armbruster wrote:
> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
> index bd3121e..a7d6b2b 100644
> --- a/hw/virtio-serial-bus.c
> +++ b/hw/virtio-serial-bus.c
> @@ -642,6 +642,11 @@ static struct BusInfo virtser_bus_info = {
>      .name      = "virtio-serial-bus",
>      .size      = sizeof(VirtIOSerialBus),
>      .print_dev = virtser_bus_dev_print,
> +    .props      = (Property[]) {
> +        DEFINE_PROP_UINT32("nr", VirtIOSerialPort, id, 
> VIRTIO_CONSOLE_BAD_ID),
> +        DEFINE_PROP_STRING("name", VirtIOSerialPort, name),
> +        DEFINE_PROP_END_OF_LIST()
> +    }

'name' isn't a must-have for all devices, but this is change OK.

                Amit



reply via email to

[Prev in Thread] Current Thread [Next in Thread]