[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/21] scsi: introduce SCSIBusOps
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH v3 04/21] scsi: introduce SCSIBusOps |
Date: |
Fri, 20 May 2011 17:53:50 +0200 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
> qbus_create_inplace(&bus->qbus, &scsi_bus_info, host, NULL);
> bus->busnr = next_scsi_bus++;
> bus->tcq = tcq;
> bus->ndev = ndev;
> - bus->complete = complete;
> + bus->ops = *ops;
Normally bus->ops would be a pointer, so you can just assign it to
the address passed in instead of doing a copy. Any good reason to
do it differently here?
- [Qemu-devel] [PATCH v3 00/21] SCSI subsystem improvements, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 02/21] scsi-generic: Remove bogus double complete, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 01/21] scsi: add tracing of scsi requests, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 03/21] scsi: introduce scsi_req_data, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 04/21] scsi: introduce SCSIBusOps, Paolo Bonzini, 2011/05/17
- Re: [Qemu-devel] [PATCH v3 04/21] scsi: introduce SCSIBusOps,
Christoph Hellwig <=
- [Qemu-devel] [PATCH v3 06/21] lsi: extract lsi_find_by_tag, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 05/21] scsi: reference-count requests, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 07/21] scsi: Use 'SCSIRequest' directly, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 08/21] scsi: commonize purging requests, Paolo Bonzini, 2011/05/17