qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 04/21] scsi: introduce SCSIBusOps


From: Christoph Hellwig
Subject: Re: [Qemu-devel] [PATCH v3 04/21] scsi: introduce SCSIBusOps
Date: Fri, 20 May 2011 17:53:50 +0200
User-agent: Mutt/1.5.17 (2007-11-01)

>      qbus_create_inplace(&bus->qbus, &scsi_bus_info, host, NULL);
>      bus->busnr = next_scsi_bus++;
>      bus->tcq = tcq;
>      bus->ndev = ndev;
> -    bus->complete = complete;
> +    bus->ops = *ops;

Normally bus->ops would be a pointer, so you can just assign it to
the address passed in instead of doing a copy.  Any good reason to
do it differently here?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]