Re: [Qemu-devel] [PATCH 2/2] net: Dump client type 'info network'

[Jan Kiszka]

On 2011-05-20 18:02, Jan Kiszka wrote:
> On 2011-05-18 10:09, Markus Armbruster wrote:
>> Jan Kiszka <address@hidden> writes:
>>
>>> Include the client type name into the output of 'info network'. The
>>> result looks like this:
>>>
>>> (qemu) info network
>>> VLAN 0 devices:
>>>   rtl8139.0 (NIC): model=rtl8139,macaddr=52:54:00:12:34:57
>>> Devices not on any VLAN:
>>>   virtio-net-pci.0 (NIC): model=virtio-net-pci,macaddr=52:54:00:12:34:56
>>>    \ network1 (tap): fd=5
>>
>> I guess I'd prefix vc->infostr with type=WHATEVER, for consistency with
>> the command line, like this:
>>
>>   (qemu) info network
>>   VLAN 0 devices:
>>     rtl8139.0: type=nic,model=rtl8139,macaddr=52:54:00:12:34:57
>>   Devices not on any VLAN:
>>     virtio-net-pci.0: type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:56
>>      \ network1: type=tap,fd=5
> 
> That really only creates consistency for the 'user' client. Other
> clients put arbitrarily formatted strings into info_str. If it's still
> preferred that way, no big deal, just wanted to point it out.

Umm, obviously nic and tap are formatting similar, just dump and
(broken-again-by-someone) socket do not. So let's go for type=.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux