Re: [Qemu-devel] [PATCH 24/26] target-xtensa: impleme nt accurate window check

[Max Filippov]

> > +static void gen_window_check1(DisasContext *dc, unsigned r1)
> > +{
> > +    if (option_enabled(dc, XTENSA_OPTION_WINDOWED_REGISTER) &&
> > +            r1 / 4 > dc->used_window) {
> > +        TCGv_i32 pc = tcg_const_i32(dc->pc);
> > +        TCGv_i32 w = tcg_const_i32(r1 / 4);
> > +
> > +        gen_advance_ccount(dc);
> > +        gen_helper_window_check(pc, w);
> > +
> > +        tcg_temp_free(w);
> > +        tcg_temp_free(pc);
> > +    }
> 
> dc->used_window is never set to non-zero.  I assume you meant
> to do that here?

Oops (. Thank you, indeed.

Thanks.
-- Max