Re: [Qemu-devel] [PATCH 2/3] softfloat: extract softfloat-target.h

[Paolo Bonzini]

On 05/20/2011 09:38 PM, Blue Swirl wrote:
> On Thu, May 19, 2011 at 4:47 PM, Paolo Bonzini<address@hidden>  wrote:
> >  Most definitions in softfloat.h are really target-independent.  Split
> >  the few that stand out as target-dependent, to allow including
> >  softfloat.h from files that are not compiled per-target.
>
> Maybe the next step should be (or in place of this patch) to move the
> various defines to target-xyz/cpu.h?

Not sure...  Adding (or increasing, I haven't checked) the dependency of 
softfloat on */cpu.h is bad, but a new file 
target-xyz/softfloat-target.h would be feasible.  You'd miss the 
classification in the two big groups (sNAN sign bit = 0/1), but that's 
not a big deal.

Regarding "in place of this patch" however I disagree, since this patch 
is a naive split of a file in two big pieces, while your proposal 
requires more thought.

Paolo