[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Consistently use qemu_macaddr_default_if_unset
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH] Consistently use qemu_macaddr_default_if_unset |
|
Date: |
Mon, 23 May 2011 11:33:19 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-05-23 10:43, Markus Armbruster wrote:
> Jan Kiszka <address@hidden> writes:
>
>> Drop the open-coded MAC assignment from net_init_nic and replace it with
>> standard qemu_macaddr_default_if_unset which is also used by qdev. That
>> avoid creating colliding MACs when instantiating NICs via different
>> mechanisms.
>
> Should we explicitly mention that this may change default MAC addresses?
Only if mixing old (-net) and new (-device) mechanisms.
>
>> This change requires to store the MAC as MACAddr in NICInfo, and the
>> remaining nd_table users need to be updated.
>>
>> Based on suggestion by Peter Maydell.
>
> Patch looks fine to me.
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux