[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/5] virtio-serial: Drop useless property is_console
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 3/5] virtio-serial: Drop useless property is_console |
Date: |
Wed, 25 May 2011 14:21:12 +0200 |
All you could ever achieve with it is break stuff, so removing it
should be safe.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/virtio-console.c | 2 --
hw/virtio-serial.h | 3 ---
2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 50b85f8..180ac0a 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@ -91,7 +91,6 @@ static int virtconsole_initfn(VirtIOSerialPort *port)
{
VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port);
- port->is_console_dummy = true;
return generic_port_init(vcon, port);
}
@@ -117,7 +116,6 @@ static VirtIOSerialPortInfo virtconsole_info = {
.init = virtconsole_initfn,
.exit = virtconsole_exitfn,
.qdev.props = (Property[]) {
- DEFINE_PROP_UINT8("is_console", VirtConsole, port.is_console_dummy, 1),
DEFINE_PROP_UINT32("nr", VirtConsole, port.id, VIRTIO_CONSOLE_BAD_ID),
DEFINE_PROP_CHR("chardev", VirtConsole, chr),
DEFINE_PROP_STRING("name", VirtConsole, port.name),
diff --git a/hw/virtio-serial.h b/hw/virtio-serial.h
index c0d1717..acf049d 100644
--- a/hw/virtio-serial.h
+++ b/hw/virtio-serial.h
@@ -119,9 +119,6 @@ struct VirtIOSerialPort {
uint32_t iov_idx;
uint64_t iov_offset;
- /* For property backward compatibility, not used otherwise */
- uint8_t is_console_dummy;
-
/* Is the corresponding guest device open? */
bool guest_connected;
/* Is this device open for IO on the host? */
--
1.7.2.3
- [Qemu-devel] [PATCH 0/5] virtio-serial: Fixes and cleanups, Markus Armbruster, 2011/05/25
- Re: [Qemu-devel] [PATCH 0/5] virtio-serial: Fixes and cleanups, Amit Shah, 2011/05/25
- [Qemu-devel] [PATCH 3/5] virtio-serial: Drop useless property is_console,
Markus Armbruster <=
- [Qemu-devel] [PATCH 5/5] virtio-console: Simplify init callbacks, Markus Armbruster, 2011/05/25
- [Qemu-devel] [PATCH 2/5] virtio-serial: Clean up virtconsole detection, Markus Armbruster, 2011/05/25
- [Qemu-devel] [PATCH 1/5] virtio-serial: Plug memory leak on qdev exit(), Markus Armbruster, 2011/05/25
- [Qemu-devel] [PATCH 4/5] virtio-serial: Drop redundant VirtIOSerialPort member info, Markus Armbruster, 2011/05/25