[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 20/25] scsi: make write_data return void
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v5 20/25] scsi: make write_data return void |
Date: |
Thu, 26 May 2011 12:56:46 +0200 |
The return value is unused anyway.
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Christoph Hellwig <address@hidden>
---
hw/scsi-disk.c | 6 ++----
hw/scsi-generic.c | 7 ++-----
hw/scsi.h | 2 +-
3 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index f3eba52..e0c384f 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -269,7 +269,7 @@ static void scsi_write_complete(void * opaque, int ret)
}
}
-static int scsi_write_data(SCSIRequest *req)
+static void scsi_write_data(SCSIRequest *req)
{
SCSIDiskReq *r = DO_UPCAST(SCSIDiskReq, req, req);
SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, r->req.dev);
@@ -281,7 +281,7 @@ static int scsi_write_data(SCSIRequest *req)
if (r->req.cmd.mode != SCSI_XFER_TO_DEV) {
DPRINTF("Data transfer direction invalid\n");
scsi_write_complete(r, -EINVAL);
- return 0;
+ return;
}
n = r->iov.iov_len / 512;
@@ -296,8 +296,6 @@ static int scsi_write_data(SCSIRequest *req)
/* Invoke completion routine to fetch data from host. */
scsi_write_complete(r, 0);
}
-
- return 0;
}
static void scsi_dma_restart_bh(void *opaque)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index fc015e0..579bab9 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -277,7 +277,7 @@ static void scsi_write_complete(void * opaque, int ret)
/* Write data to a scsi device. Returns nonzero on failure.
The transfer may complete asynchronously. */
-static int scsi_write_data(SCSIRequest *req)
+static void scsi_write_data(SCSIRequest *req)
{
SCSIGenericState *s = DO_UPCAST(SCSIGenericState, qdev, req->dev);
SCSIGenericReq *r = DO_UPCAST(SCSIGenericReq, req, req);
@@ -287,16 +287,13 @@ static int scsi_write_data(SCSIRequest *req)
if (r->len == 0) {
r->len = r->buflen;
scsi_req_data(&r->req, r->len);
- return 0;
+ return;
}
ret = execute_command(s->bs, r, SG_DXFER_TO_DEV, scsi_write_complete);
if (ret < 0) {
scsi_command_complete(r, ret);
- return 1;
}
-
- return 0;
}
/* Return a pointer to the data buffer. */
diff --git a/hw/scsi.h b/hw/scsi.h
index 5730faa..b56338d 100644
--- a/hw/scsi.h
+++ b/hw/scsi.h
@@ -77,7 +77,7 @@ struct SCSIDeviceInfo {
void (*free_req)(SCSIRequest *req);
int32_t (*send_command)(SCSIRequest *req, uint8_t *buf);
void (*read_data)(SCSIRequest *req);
- int (*write_data)(SCSIRequest *req);
+ void (*write_data)(SCSIRequest *req);
void (*cancel_io)(SCSIRequest *req);
uint8_t *(*get_buf)(SCSIRequest *req);
int (*get_sense)(SCSIRequest *req, uint8_t *buf, int len);
--
1.7.4.4
- [Qemu-devel] [PATCH v5 08/25] scsi: Use 'SCSIRequest' directly, (continued)
- [Qemu-devel] [PATCH v5 08/25] scsi: Use 'SCSIRequest' directly, Paolo Bonzini, 2011/05/26
- [Qemu-devel] [PATCH v5 18/25] scsi: Implement 'get_sense' callback, Paolo Bonzini, 2011/05/26
- [Qemu-devel] [PATCH v5 15/25] scsi: introduce scsi_req_new, Paolo Bonzini, 2011/05/26
- [Qemu-devel] [PATCH v5 19/25] scsi-disk: add data direction checking, Paolo Bonzini, 2011/05/26
- [Qemu-devel] [PATCH v5 21/25] scsi-generic: Handle queue full, Paolo Bonzini, 2011/05/26
- [Qemu-devel] [PATCH v5 22/25] esp: rename sense to status, Paolo Bonzini, 2011/05/26
- [Qemu-devel] [PATCH v5 23/25] scsi: split command_complete callback in two, Paolo Bonzini, 2011/05/26
- [Qemu-devel] [PATCH v5 24/25] scsi: rename arguments to the new callbacks, Paolo Bonzini, 2011/05/26
- [Qemu-devel] [PATCH v5 25/25] scsi: ignore LUN field in the CDB, Paolo Bonzini, 2011/05/26
- [Qemu-devel] [PATCH v5 05/25] scsi-generic: do not use a stale aiocb, Paolo Bonzini, 2011/05/26
- [Qemu-devel] [PATCH v5 20/25] scsi: make write_data return void,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL v5 00/25] SCSI subsystem improvements, Anthony Liguori, 2011/05/31