Re: [Qemu-devel] [PATCH] target-ppc: Fix compilation error with --enable-debug

[Alexander Graf]

Am 26.05.2011 um 20:28 schrieb Stefan Weil <address@hidden>:

> Am 26.05.2011 20:05, schrieb Peter Maydell:
>> The PPC helper functions booke206_tlbflush and booke_setpid both
>> take an i32 argument, so we need to use TCGv_i32 rather than TCGv,
>> to avoid a compilation failure when compiling in debug mode.
>> 
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> target-ppc/translate_init.c | 8 ++++----
>> 1 files changed, 4 insertions(+), 4 deletions(-)
>> 
> 
> See http://patchwork.ozlabs.org/patch/96665/
> 
> It's a waste of time if build fixes take more than 3 days to get committed.
> 
> The typical process - several days until the maintainer accepts it, more
> days until there is a pull request, even more days until it is pulled -
> is good enough for new features, but too slow for bug fixes, especially
> when they fix broken builds.

I agree, but I think the solution to the problem is to not break builds. I'm 
currently spending all day setting up kvm-autotest for automated regression 
testing and am eagerly waiting on Stefan to get the buildbot stuff rolling on 
submaintainer trees.

With those two things in place, we should be a lot safer.


Alex

>