Re: [Qemu-devel] [PATCH 00/12] target-s390x: Several small fixes

[Alexander Graf]

On 27.05.2011, at 06:59, Stefan Weil wrote:

> Am 26.05.2011 23:48, schrieb Andreas Färber:
>> Am 26.05.2011 um 00:17 schrieb Alexander Graf:
>> 
>>> On 26.05.2011, at 00:10, Peter Maydell wrote:
>>> 
>>>> On 25 May 2011 21:25, Stefan Weil <address@hidden> wrote:
>>>>> Feel free to combine patches if larger patches are preferred.
>>>> 
>>>> I'd vote for combining at least 03..12, having nine patches all
>>>> of which have the same summary line is a bit confusing :-)
>>> 
>>> I actually like them as individual patches. Makes bisecting a lot easier :).
>> 
>> Stefan, could you add the function name or some other discriminator to the 
>> subject then, please?
>> 
>> Andreas
> 
> This would result in these subjects:
> 
> 4 x target-s390x: Add missing tcg_temp_free_i64() in disas_a5
> 2 x target-s390x: Add missing tcg_temp_free_i64() in disas_s390_insn

Inside the functions there's a switch that determines the actual opcode. Just 
use that in the name?


Alex