Re: [Qemu-devel] [RFC PATCH 3/6] scsi-generic: allow customization of the lun

[Paolo Bonzini]

On 05/27/2011 03:04 PM, Christoph Hellwig wrote:
> Requiring this code in the scsi drivers is a really bad idea.  Not only
> does it mean duplicating the implementation of REPORT LUNS and the illegal
> LUN version of INQUIRY in every scsi LUN handler and the target driver,
> but also an inconsitent topology of the qemu-internal objects representing
> the SCSI implementation, which is a pretty clear path to all kinds of nast
> bugs only showing up for the legacy case some time down the road.
>
> The right way to solve this is to make sure we always have the proper
> target object by creating it under the hood for the legacy case.

I know, but this requires changes to the basic qdev layer so I planned 
to do this later.  Also because for bisectability, to avoid dropping a 
huge patch, I first need to work around the legacy cases and then kill them.

Paolo