[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/12] target-s390x: Add missing tcg_temp_fre
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/12] target-s390x: Add missing tcg_temp_free_i64() in disas_a5(), opc == 0x8 |
Date: |
Sat, 28 May 2011 02:08:54 +0200 |
On 27.05.2011, at 19:03, Stefan Weil wrote:
> load_reg() needs a matching tcg_temp_free_i64().
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> target-s390x/translate.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-s390x/translate.c b/target-s390x/translate.c
> index 81b8c5b..692de6e 100644
> --- a/target-s390x/translate.c
> +++ b/target-s390x/translate.c
> @@ -2365,6 +2365,7 @@ static void disas_a5(DisasContext *s, int op, int r1,
> int i2)
> tcg_gen_shri_i64(tmp2, tmp, 48);
> tcg_gen_trunc_i64_i32(tmp32, tmp2);
> set_cc_nz_u32(s, tmp32);
> + tcg_temp_free_i64(tmp);
tmp gets freed at the end of the function, so this one is bad.
Alex
- Re: [Qemu-devel] [PATCH 00/12] target-s390x: Several small fixes, (continued)
[Qemu-devel] [PATCH v2 00/12] target-s390x: Several small fixes, Stefan Weil, 2011/05/27
[Qemu-devel] [PATCH v2 03/12] target-s390x: Add missing tcg_temp_free_i64() in gen_jcc(), Stefan Weil, 2011/05/27
[Qemu-devel] [PATCH v2 12/12] target-s390x: Add missing tcg_temp_free_i32(), Stefan Weil, 2011/05/27
[Qemu-devel] [PATCH v2 05/12] target-s390x: Add missing tcg_temp_free_i64() in disas_b2(), Stefan Weil, 2011/05/27
[Qemu-devel] [PATCH v2 08/12] target-s390x: Add missing tcg_temp_free_i64() in disas_a5(), opc == 0x8, Stefan Weil, 2011/05/27
- Re: [Qemu-devel] [PATCH v2 08/12] target-s390x: Add missing tcg_temp_free_i64() in disas_a5(), opc == 0x8,
Alexander Graf <=
[Qemu-devel] [PATCH v2 09/12] target-s390x: Add missing tcg_temp_free_i64() in disas_a5(), opc == 0x9, Stefan Weil, 2011/05/27
[Qemu-devel] [PATCH v2 01/12] target-s390x: Fix wrong argument in call of tcg_gen_shl_i64(), Stefan Weil, 2011/05/27
[Qemu-devel] [PATCH v2 07/12] target-s390x: Add missing tcg_temp_free_i64() in disas_s390_insn(), opc == 0x90, Stefan Weil, 2011/05/27
[Qemu-devel] [PATCH v2 10/12] target-s390x: Add missing tcg_temp_free_i64() in disas_a5(), opc == 0xa, Stefan Weil, 2011/05/27
[Qemu-devel] [PATCH v2 06/12] target-s390x: Add missing tcg_temp_free_i64() in disas_s390_insn(), opc == 0x8e, Stefan Weil, 2011/05/27
[Qemu-devel] [PATCH v2 02/12] target-s390x: Fix duplicate call of tcg_temp_new_i64, Stefan Weil, 2011/05/27
[Qemu-devel] [PATCH v2 11/12] target-s390x: Add missing tcg_temp_free_i64() in disas_a5(), opc == 0xb, Stefan Weil, 2011/05/27
[Qemu-devel] [PATCH v2 04/12] target-s390x: Add missing tcg_temp_free_i64() in do_mh(), Stefan Weil, 2011/05/27