Re: [Qemu-devel] [patch 6/7] QEMU live block copy

[Avi Kivity]

On 05/24/2011 12:31 AM, Marcelo Tosatti wrote:
> Support live image copy + switch. That is, copy an image backing
> a guest hard disk to a destination image (destination image must
> be created separately), and switch to this copy.
>
> Command syntax:
>
> block_copy device filename [-i] -- live block copy device to image
>               -i for incremental copy (base image shared between src and 
> destination)
>
> Please refer to qmp-commands diff for more details.

IMO it would have been nicer to use the mirror driver for all copying; 
there would be no STAGE_DIRTY; simply a background process that copies 
over all blocks, taking care not to conflict with ongoing writes.  It 
would also remove the conflict with migration.

But that's an implementation detail and can be changed later.

--
error compiling committee.c: too many arguments to function