Re: [Qemu-devel] [PATCH] host-pcc: enable building with -m32 or -m64

[Stefan Berger]

On 05/29/2011 05:09 PM, Andreas Färber wrote:
> Am 27.05.2011 um 00:25 schrieb Stefan Berger:
>
> > On 05/26/2011 05:24 PM, Andreas Färber wrote:
> > > Am 26.05.2011 um 22:31 schrieb Stefan Berger:
> > >
> > > > On 05/26/2011 04:20 PM, Andreas Färber wrote:
> > > > > Am 26.05.2011 um 21:00 schrieb Stefan Berger:
> > > > >
> > > > > > With the below patch I can build either ppc (-m32) or ppc64 
> > > > > > (-m64) versions of Qemu (on a ppc64 host) when passing these 
> > > > > > compiler flags via 'configure ... --extra-cflags="-m32"'.
> > > > >
> > > > > You probably meant "without passing"?
> > > > >
> > > > > Nack. Please don't hardcode -mXX in configure, it's -arch ppc vs. 
> > > > > -arch ppc64 on my host/gcc. What's wrong with passing --extra-cflags?
> > > > I posted the following patch today for compiling libcacard with 
> > > > -m32 on a 64 bit machine.
> > > >
> > > > http://lists.nongnu.org/archive/html/qemu-devel/2011-05/msg02909.html
> > > >
> > > > It adds LDFLAGS. This works fine on x86-64. Then trying this out on 
> > > > ppc64 with -m32 in extra-cflags I find the following in 
> > > > config-host.mak
> > > >
> > > > [...]
> > > > HELPER_CFLAGS=
> > > > LDFLAGS=-Wl,--warn-common -g
> > > > ARLIBS_BEGIN=
> > > > [...]
> > > >
> > > > The -m32 doesn't make it into LDFLAGS. The below patch fixed it for 
> > > > me following the pattern of x86-64 and i686 a bit further up in the 
> > > > case statement in configure.
> > >
> > > Erm, you did try --extra-ldflags for LDFLAGS, did you? That 
> > > --extra-cflags doesn't end up there is intentional!
> > No, I didn't. Here's what happened. On x86_64 host I used to be able 
> > to compile 32bit executables with --extra-cflags="-m32". That stopped 
> > working when libcacard showed up -- I posted a patch today -- only 
> > the linking of vscclient in libcacard/ didn't work. The "work-around" 
> > before the patch was --disable-smartcard. Now taking that same habit 
> > of passing --extra-cflags="-m32" to the ppc64 machine again didn't 
> > work, but was broken somewhere else. So this is where this is all 
> > coming from.
>
> Stefan, I rather care about where this is going, and my unanswered 
> question is: Does it work if you use --extra-cflags=-m32 
> --extra-ldflags=-m32?
> If yes, then we can drop this patch and be good. Otherwise we need to 
> think about a better solution.
It works as you show above once this patch here has been applied:

http://lists.nongnu.org/archive/html/qemu-devel/2011-05/msg02909.html

   Stefan