qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 08/14] usb-linux: Don't try to open the same device


From: Hans de Goede
Subject: [Qemu-devel] [PATCH 08/14] usb-linux: Don't try to open the same device twice
Date: Tue, 31 May 2011 11:35:24 +0200

If a user wants to redirect 2 identical usb sticks, in theory this is
possible by doing:
usb_add host:1234:5678
usb_add host:1234:5678

But this will lead to us trying to open the first stick twice, since we
don't break the loop after having found a match in our filter list, so the next'
filter list entry will result in us trying to open the same device again.

Fix this by adding the missing break.
---
 usb-linux.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/usb-linux.c b/usb-linux.c
index 334012e..eb9805b 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -1689,6 +1689,7 @@ static int usb_host_auto_scan(void *opaque, int bus_num, 
int addr, char *port,
                a qdev from its initfn is not allowed. */
             s->open_failed = ret;
         }
+        break;
     }
 
     return 0;
-- 
1.7.5.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]