[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/14] usb-linux: Don't try to open the same device
From: |
Hans de Goede |
Subject: |
[Qemu-devel] [PATCH 08/14] usb-linux: Don't try to open the same device twice |
Date: |
Tue, 31 May 2011 11:35:24 +0200 |
If a user wants to redirect 2 identical usb sticks, in theory this is
possible by doing:
usb_add host:1234:5678
usb_add host:1234:5678
But this will lead to us trying to open the first stick twice, since we
don't break the loop after having found a match in our filter list, so the next'
filter list entry will result in us trying to open the same device again.
Fix this by adding the missing break.
---
usb-linux.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/usb-linux.c b/usb-linux.c
index 334012e..eb9805b 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -1689,6 +1689,7 @@ static int usb_host_auto_scan(void *opaque, int bus_num,
int addr, char *port,
a qdev from its initfn is not allowed. */
s->open_failed = ret;
}
+ break;
}
return 0;
--
1.7.5.1
- [Qemu-devel] [PATCH 00/14] usb: various usb fixes, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 01/14] usb-linux: Set usb_auto_timer to NULL after deleting it, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 02/14] usb-linux: Get speed from sysfs rather then from the connectinfo ioctl, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 04/14] usb-linux: Don't do perror when errno is not set, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 05/14] usb-linux: Don't call usb_host_close when usb_host_open fails, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 06/14] usb-linux: Ensure devep != 0, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 03/14] usb-linux: Teach about super speed, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 07/14] usb-linux: If opening a device fails remove it from our filter list, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 08/14] usb-linux: Don't try to open the same device twice,
Hans de Goede <=
- [Qemu-devel] [PATCH 10/14] usb-linux: Enlarge buffer for descriptors to 8192 bytes, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 09/14] usb-linux: Don't declare a usbdevice_name, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 11/14] usb-bus: Add knowledge of USB_SPEED_SUPER to usb_speed helper, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 12/14] usb-bus: Don't allow attaching a device to a bus with no free ports, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors, Hans de Goede, 2011/05/31