Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors

[Michael Tokarev]

31.05.2011 13:35, Hans de Goede wrote:
> ---
>  hw/usb-bus.c |   23 ++++++++++++-----------
>  hw/usb-msd.c |    5 +++--
>  usb-linux.c  |    6 +++++-
>  3 files changed, 20 insertions(+), 14 deletions(-)
> 
> diff --git a/hw/usb-bus.c b/hw/usb-bus.c
> index 0a49921..2ae2678 100644
> --- a/hw/usb-bus.c
> +++ b/hw/usb-bus.c

>      if (dev->attached) {
> -        fprintf(stderr, "Warning: tried to attach usb device %s twice\n",
> +        fprintf(stderr, "Error: tried to attach usb device %s twice\n",
>                  dev->product_desc);

qemu_error() maybe, while we're at it?
Here and in a few other places.

Thanks!

/mjt