Re: [Qemu-devel] [PATCH] Fix libfdt warnings on Darwin

[Andreas Färber]

Am 28.05.2011 um 16:20 schrieb Alexander Graf:

> On 28.05.2011, at 16:16, Andreas Färber wrote:
>
> > Am 28.05.2011 um 16:03 schrieb Alexander Graf:
> >
> > > On 28.05.2011, at 16:01, Andreas Färber wrote:
> > >
> > > > diff --git a/libfdt_env.h b/libfdt_env.h
> > > > index ee0419f..90d7f3b 100644
> > > > --- a/libfdt_env.h
> > > > +++ b/libfdt_env.h
> > > > @@ -19,13 +19,9 @@
> > > > #ifndef _LIBFDT_ENV_H
> > > > #define _LIBFDT_ENV_H
> > > >
> > > > -#include <stddef.h>
> > > > -#include <stdint.h>
> > > > -#include <string.h>
> > > > -#include <endian.h>
> > > > -#include <byteswap.h>
> > > > +#include "bswap.h"
> > > >
> > > > -#if __BYTE_ORDER == __BIG_ENDIAN
> > > > +#ifdef HOST_WORDS_BIGENDIAN
> > >
> > > Hrm. Who defines HOST_WORDS_BIGENDIAN? Shouldn't you explicitly  
> > > include that header file?
> >
> > bswap.h includes config-host.h, why duplicate that. Let's not make  
> > Stefan more work. :)
>
> Ah, then everything's fine :). Please make sure to test it on a  
> little endian (Linux) box as well :)
>
> Acked-by: Alexander Graf <address@hidden>

Thanks, applied to cocoa branch.

Andreas