qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/14] usb-linux: Set usb_auto_timer to NULL aft


From: Hans de Goede
Subject: Re: [Qemu-devel] [PATCH 01/14] usb-linux: Set usb_auto_timer to NULL after deleting it
Date: Wed, 01 Jun 2011 16:24:48 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Lightning/1.0b2 Thunderbird/3.1.10

Hi,

On 06/01/2011 12:48 PM, Gerd Hoffmann wrote:
On 05/31/11 11:35, Hans de Goede wrote:
We might check for it being NULL later, if the device gets unplugged.
---
usb-linux.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/usb-linux.c b/usb-linux.c
index 4d7a31a..ea3ab5f 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -1675,6 +1675,7 @@ static void usb_host_auto_check(void *unused)
/* nothing to watch */
if (usb_auto_timer) {
qemu_del_timer(usb_auto_timer);
+ usb_auto_timer = NULL;

This is wrong.

qemu_del_timer just removes the scheduled timer event, not the timer structure 
itself. qemu_free_timer does the later.


Ok, I stand corrected :)

Regards,

Hans



reply via email to

[Prev in Thread] Current Thread [Next in Thread]