[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 2/3] Cocoa: avoid displaying window when comm
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH V2 2/3] Cocoa: avoid displaying window when command-line contains '-h' or '-help' |
Date: |
Thu, 2 Jun 2011 07:10:52 +0100 |
On 2 June 2011 00:05, Andreas Färber <address@hidden> wrote:
> Am 30.05.2011 um 00:32 schrieb Peter Maydell:
>> (1) presumably this doesn't work if you disable the display
>> with "-display none" ?
>
> I don't see how that would not work. It's just not handled specially here,
> so it will likely display a window - the former behavior of all these
> switches.
Yes, that's my point -- this chunk of code is trying to implement
"don't bring up the display window if we won't use it", and it
doesn't work properly [ie does not suppress the window in all the
cases where it should] because inevitably it lags behind the
set of options in vl.c which don't bring up the display window.
I don't particularly object to the patch being committed as a short
term measure.
-- PMM