Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction

[Andreas Färber]

Am 02.06.2011 um 04:21 schrieb Alexandre Raymond:

> Fix the following warning by including signal.h directly in qemu- 
> common.h
> ----8<----
> iohandler.c: In function ‘qemu_init_child_watch’:
> iohandler.c:172: warning: implicit declaration of function ‘sigaction’
> iohandler.c:172: warning: nested extern declaration of ‘sigaction’
> ----8<----
>
> Signed-off-by: Alexandre Raymond <address@hidden>

Tested-by: Andreas Färber <address@hidden>

Why in qemu-common.h and not in iohandler.c though?
If we put it into qemu-common.h, you should remove other inclusions of  
signal.h.

Andreas

> ---
> qemu-common.h |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-common.h b/qemu-common.h
> index b851b20..39fabc9 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -39,6 +39,7 @@ typedef struct Monitor Monitor;
> #include <sys/stat.h>
> #include <sys/time.h>
> #include <assert.h>
> +#include <signal.h>
>
> #ifdef _WIN32
> #include "qemu-os-win32.h"
> --
> 1.7.5