Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

[malc]

On Fri, 3 Jun 2011, Aurelien Jarno wrote:

> On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote:
> > pulse/simple.h does not include stdlib.h
> > We cannot use NULL since it may not be defined
> > Use 0 instead
> 
> I am unable to reproduce this issue, even with gcc-4.6. Also please note
> that NULL is defined in <stddef.h>, not <stdlib.h>. <stddef.h> is 
> included from <sys/types.h> which is included from <pulse/simple.h>.
> 
> Do you have more information about the issue.
> 
> > Signed-off-by: Marc-Antoine Perennou <address@hidden>
> > ---
> >  configure |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/configure b/configure
> > index ea8b676..d67c3ce 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1567,7 +1567,7 @@ for drv in $audio_drv_list; do
> > 
> >      pa)
> >      audio_drv_probe $drv pulse/simple.h "-lpulse-simple -lpulse" \
> > -        "pa_simple *s = NULL; pa_simple_free(s); return 0;"
> > +        "pa_simple *s = 0; pa_simple_free(s); return 0;"
> 
> It should be ((void*)0) instead of simply 0.

No it shouldn't.

> 
> >      libs_softmmu="-lpulse -lpulse-simple $libs_softmmu"
> >      audio_pt_int="yes"
> >      ;;
> > -- 
> > 1.7.5.52.ge839f.dirty
> > 
> > 
> 
> 

-- 
mailto:address@hidden