Re: [Qemu-devel] [Bug 793317] [NEW] Large amount of write-only variables

[agraf]

On 06.06.2011, at 08:06, David Gibson wrote:

> On Mon, Jun 06, 2011 at 01:02:33AM -0000, Eli wrote:
>> Public bug reported:
>> 
>> Whenever I try to compile the source from the git repo, it gets a large
>> number of "set but not used" errors, in files such as:
>> 
>> hw/usb_ochi.c (line 526, 1114, and 1108)
>> hw/lsi53c895a.c (line 892)
>> kvm.c (line 973)
>> target-alpha/translate.c (line 1472, 1470)
>> linux-user/syscall.c (line 7062, 3754)
>> exec.c (line 1211)
>> linux-user/linuxload.c (line 60)
>> 
>> Really now, why would anyone create so many write-only variables knowing
>> that it's compiled with write-only variables causing errors..?
> 
> It's a new warning in gcc 4.6, which is why these weren't found
> before.

Yeah, for a quick compile workaround, use ./configure --disable-werror.
Otherwise, please send patches that get rid of the write-only variables.
People simply didn't get warnings on them before, which is why they
slipped through.

Alex

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/793317

Title:
  Large amount of write-only variables

Status in QEMU:
  New

Bug description:
  Whenever I try to compile the source from the git repo, it gets a
  large number of "set but not used" errors, in files such as:

  hw/usb_ochi.c (line 526, 1114, and 1108)
  hw/lsi53c895a.c (line 892)
  kvm.c (line 973)
  target-alpha/translate.c (line 1472, 1470)
  linux-user/syscall.c (line 7062, 3754)
  exec.c (line 1211)
  linux-user/linuxload.c (line 60)

  Really now, why would anyone create so many write-only variables
  knowing that it's compiled with write-only variables causing errors..?

  Host: Fedora 15 i686
  Gcc: 4.6.0
  Guest: None
  I pulled the code from the git repo earlier today, so I'm pretty sure it did 
not get fixed in that short timeframe.