Re: [Qemu-devel] [0/7] USB UVC updates

[Natalia Portillo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Brad,

El 02/06/2011, a las 06:41, Brad Hards escribió:

> Hi Natalia,
> 
> As you suggested, I've stopped my nonsense and worked from your
> UVC patches (http://patchwork.ozlabs.org/patch/55001 and
> http://patchwork.ozlabs.org/patch/55000). These changes
> are relative to your patches (applied on top of trunk).
> 
> I've mostly just incorporated some changes requested by Blue
> Swirl in his review. Fixing the checkpatch stuff changed a lot
> of whitespace (tab -> spaces), so I'd like to make sure this is
> OK before making more changes.

I see it ok, have you tested nothing broken? (specially with the &s patch)
I should take more care with 's's in typos next time

> The next change I propose to make is to rework the descriptors
> and add constants / defines for magic numbers.

Yeah, there are a couple of magic numbers that can be added.
Please note that most of the constants used in the descriptors should go
in usb.h

Also take special care with the descriptors, the minimal change can break it 
very easily.
The ideal solution would be to make the descriptors be dynamic depending on the 
host
webcam capabilities.

Bad thing the USB IF put the resolutions and formats in the descriptor, instead 
of in a
query command.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org

iF0EAREIAAYFAk3snrEACgkQv/wfOsykIRRbngD492YNOzZGwRgwwVqok+AewO6H
kXvTClUJibR4fTVaDgEArEqcnm/xLF8gvANDc7DX6l8z7jOY8pagK4V488PMOhI=
=gzkf
-----END PGP SIGNATURE-----