[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] m68k: Replace gen_im32() by tcg_
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] m68k: Replace gen_im32() by tcg_const_i32() |
Date: |
Tue, 7 Jun 2011 14:56:19 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Jun 05, 2011 at 12:26:18PM +0200, Andreas Färber wrote:
> I would add as description: "This resolves a FIXME."
>
> Is "by" grammatically correct here? I would've thought to replace
> sth. "with" sth., by s.o.
>
> Am 25.03.2011 um 20:36 schrieb Laurent Vivier:
>
> >Signed-off-by: Laurent Vivier <address@hidden>
>
> This patch accurately inlines and removes gen_im32().
>
> Reviewed-by: Andreas Färber <address@hidden>
>
> Stefan, this patch was sent the third time already, nobody else
> commented. It applies cleanly and compiles. Can we consider it a
> trivial patch and be done with it?
>
> http://patchwork.ozlabs.org/patch/88417/
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan