[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/12] Add kernel header update script
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 01/12] Add kernel header update script |
Date: |
Wed, 8 Jun 2011 15:33:58 +0100 |
On 8 June 2011 15:10, Jan Kiszka <address@hidden> wrote:
> --- /dev/null
> +++ b/scripts/update-linux-headers.sh
> @@ -0,0 +1,55 @@
> +#!/bin/sh -e
> +#
> +if [ -z "$output" ]; then
> + output=$PWD
> +fi
> + mkdir -p $output/linux-headers/asm-$arch
This script is rather lacking in quoting throughout. As a random
example, this looks like it will break if you run the script from
a directory with a space in the path.
> +tmpdir=$TMPDIR/.tmp-hdrs-$$
Better (safer) to use mktemp, I think.
> if [ -z "$linux" -o ! -d "$linux" ]; then
test -o is obsolescent in POSIX; use
if [ -z "$linux" ] || ! [ -d "$linux" ] ; then
instead.
-- PMM
- [Qemu-devel] [PATCH 00/12] [uq/master] Import linux headers and some cleanups, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH 09/12] kvm: ppc: Drop KVM_CAP build dependencies, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH 05/12] kvm: ppc: Drop CONFIG_KVM_PPC_PVR, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH 01/12] Add kernel header update script, Jan Kiszka, 2011/06/08
- Re: [Qemu-devel] [PATCH 01/12] Add kernel header update script,
Peter Maydell <=
- [Qemu-devel] [PATCH v2 01/12] Add kernel header update script, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH v3 01/12] Add kernel header update script, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH 04/12] kvm: Drop CONFIG_KVM_PARA, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH 08/12] kvm: x86: Drop KVM_CAP build dependencies, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH 12/12] Remove unneeded kvm.h from cpu-exec.c, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH 07/12] kvm: Drop KVM_CAP build dependencies, Jan Kiszka, 2011/06/08