[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci de
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them |
|
Date: |
Wed, 08 Jun 2011 22:48:10 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-06-08 21:53, Michael S. Tsirkin wrote:
> On Wed, Jun 08, 2011 at 06:21:51PM +0200, Jan Kiszka wrote:
>> Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related constant
>> names to libpci style. Will be used for device assignment code in
>> qemu-kvm.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>
> Besides keeping pci_regs.h aligned with the original,
> I also think ideally pci register banging should stay
> within the pci subsystem.
>
> Could we add high-level APIs to help with that,
> instead of having kvm look at config space directly?
We could move the related static inlines from msi/msix.c to the headers
in order to test for bits etc. Still, kvm needs to interpret the config
space of the assigned device, so the abstraction will remain rather low.
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/9] msi: Small cleanups and fixes, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH v2 3/9] msi: Guard msi_reset with msi_present, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH v2 4/9] msi: Use msi/msix_present more consistently, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH v2 7/9] msi: Invoke msi/msix_uninit from PCI core, Jan Kiszka, 2011/06/08
- [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them, Jan Kiszka, 2011/06/08
- Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them, Michael S. Tsirkin, 2011/06/08
- Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them, Michael S. Tsirkin, 2011/06/08
- Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them,
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them, Michael S. Tsirkin, 2011/06/08
- Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them, Jan Kiszka, 2011/06/08
- Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them, Michael S. Tsirkin, 2011/06/08
- Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them, Jan Kiszka, 2011/06/08
- Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them, Michael S. Tsirkin, 2011/06/08
[Qemu-devel] [PATCH v2 5/9] msi: Invoke msi/msix_reset from PCI core, Jan Kiszka, 2011/06/08
[Qemu-devel] [PATCH v2 9/9] msi: Move PCI_MSI_PENDING_32/64 into pci_regs.h, Jan Kiszka, 2011/06/08