Re: [Qemu-devel] [PATCH v2][ 05/21] qapi: add qapi-types.py code generator

[Markus Armbruster]

Anthony Liguori <address@hidden> writes:

> On 06/03/2011 05:33 PM, Michael Roth wrote:
>> This is the code generator for qapi types. It will generation the
>> following files:
>>
>>    $(prefix)qapi-types.h - C types corresponding to types defined in
>>                            the schema you pass in
>>    $(prefix)qapi-types.c - Cleanup functions for the above C types
>>
>> The $(prefix) is used to as a namespace to keep the generated code from
>> one schema/code-generation separated from others so code and be
>> generated from multiple schemas with clobbering previously created code.
>>
>> Signed-off-by: Michael Roth<address@hidden>
>> ---
>>   scripts/qapi-types.py |  221 
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>   1 files changed, 221 insertions(+), 0 deletions(-)
>>   create mode 100644 scripts/qapi-types.py
>>
>> diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
>> new file mode 100644
>> index 0000000..15603f3
>> --- /dev/null
>> +++ b/scripts/qapi-types.py
>
> Other than copyright, I think this is ready to go.
>
> Haven't seen much comments about this series.  I think we're at the
> speak now or forever hold your peace moment, so if you've got concerns
> about this approach, please speak up.

There's one concern that trumps all the others I may have: QMP needs to
move.  I feel the best I can to for that is to keep out of its way.