qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] savevm: fix corruption in vmstate_subsection


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2] savevm: fix corruption in vmstate_subsection_load().
Date: Thu, 09 Jun 2011 15:19:35 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10

On 06/09/2011 02:48 PM, Kevin Wolf wrote:
This means that subsections are silently ignored if the old version
didn't have any subsection for the device. Wasn't it a fundamental point
of the design of subsections that this would fail?

Unfortunately you cannot have it both ways because the migration format is ambiguous.

Noticed this when trying to use subsections to fix up IDE, and new ->
old migration after an I/O error only correctly fails when I revert this
patch.

I would have expected migration to fail anyway because the next instances are not parsed correctly.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]