Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

[Andreas Färber]

Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou:

> On 4 June 2011 00:54, malc <address@hidden> wrote:
> > On Sat, 4 Jun 2011, Aurelien Jarno wrote:
> >
> > > On Sat, Jun 04, 2011 at 01:57:23AM +0400, malc wrote:
> > > > On Fri, 3 Jun 2011, Aurelien Jarno wrote:
> > > >
> > > > > On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou  
> > > > > wrote:
> > > > > > diff --git a/configure b/configure
> > > > > > index ea8b676..d67c3ce 100755
> > > > > > --- a/configure
> > > > > > +++ b/configure
> > > > > > @@ -1567,7 +1567,7 @@ for drv in $audio_drv_list; do
> > > > > >
> > > > > >      pa)
> > > > > >      audio_drv_probe $drv pulse/simple.h "-lpulse-simple - 
> > > > > > lpulse" \
> > > > > > -        "pa_simple *s = NULL; pa_simple_free(s); return 0;"
> > > > > > +        "pa_simple *s = 0; pa_simple_free(s); return 0;"

> It's kinda weird actually, just wrote a small program to test:
>
> #include <stddef.h>
> int main() {
>    int * i = NULL;
>    return 0;
> }
>
> It builds fine
> Now if I replace "stddef.h" by "sys/types.h"
> ‘NULL’ undeclared
>
> I'm running Gentoo GNU/Linux [...]
>
> Manually including stddef.h or replacing NULL by 0 or (void*)0 makes  
> it work.

Then please submit a new patch that explicit includes that header with  
a comment explaining why, so that it doesn't get removed by accident.

Andreas