[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] lsi: Fix unused-but-set-variable warning
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] lsi: Fix unused-but-set-variable warning |
Date: |
Fri, 10 Jun 2011 17:36:52 +0100 |
Stefan, if you're picking up gcc warning fixes for the trivial
tree, how about this one?
(I think the other gcc warning fixes are either:
* in the most recent usb pull request
* linux-user
* target-alpha
which all have a clear owner/interested person.)
Reviewed-by: Peter Maydell <address@hidden>
-- PMM
On 1 June 2011 15:19, Paolo Bonzini <address@hidden> wrote:
> On 06/01/2011 02:56 PM, Christophe Fergeau wrote:
>>
>> This warning is new in gcc 4.6.
>>
>> Signed-off-by: Christophe Fergeau<address@hidden>
>> ---
>> hw/lsi53c895a.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
>> index 83084b6..90c6cbc 100644
>> --- a/hw/lsi53c895a.c
>> +++ b/hw/lsi53c895a.c
>> @@ -889,7 +889,6 @@ static void lsi_do_msgout(LSIState *s)
>> uint8_t msg;
>> int len;
>> uint32_t current_tag;
>> - SCSIDevice *current_dev;
>> lsi_request *current_req, *p, *p_next;
>> int id;
>>
>> @@ -901,7 +900,6 @@ static void lsi_do_msgout(LSIState *s)
>> current_req = lsi_find_by_tag(s, current_tag);
>> }
>> id = (current_tag>> 8)& 0xf;
>> - current_dev = s->bus.devs[id];
>>
>> DPRINTF("MSG out len=%d\n", s->dbc);
>> while (s->dbc) {
>
> Acked-by: Paolo Bonzini <address@hidden>