qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Reset system before loadvm


From: Jan Kiszka
Subject: Re: [Qemu-devel] [PATCH] Reset system before loadvm
Date: Tue, 14 Jun 2011 08:16:44 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2011-06-12 19:42, Peter Maydell wrote:
> On 11 June 2011 10:05, Jan Kiszka <address@hidden> wrote:
>> @@ -2074,6 +2074,7 @@ int load_vmstate(const char *name)
>>         return -EINVAL;
>>     }
>>
>> +    qemu_system_reset();
>>     ret = qemu_loadvm_state(f);
> 
> This means that if we're doing a load because the user
> passed -loadvm on the command line we'll end up doing
> qemu_system_reset() twice (once in vl.c and then again
> here). Does that matter?

I don't think it's worth optimizing. E.g. we already reset every PCI
device twice during normal reset.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]