qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img conve


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()
Date: Tue, 14 Jun 2011 16:58:23 +0100

On Tue, Jun 14, 2011 at 8:43 AM, Dmitry Konishchev <address@hidden> wrote:
> On Mon, Jun 13, 2011 at 1:13 PM, Dmitry Konishchev <address@hidden> wrote:
>> I haven't done this because in this case I have to pass too lot of
>> local variables to this function. Just not sure that it'll look
>> better. But if you mind I surely can do this.
> Should I?

Yes, please.  For image files the block layer should be caching the
device capacity (size) anyway, so you probably don't need to allocate
the array, just call bdrv_get_geometry().  That might make it easier
to write a self-contained function.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]