Re: [Qemu-devel] [PATCH 33/34] hw/usb-ohci.c: Implement remote wakeup

[Peter Maydell]

On 14 June 2011 12:05, Gerd Hoffmann <address@hidden> wrote:
> From: Peter Maydell <address@hidden>
>
> Implement the wakeup callback in the OHCI USBPortOps, so that when
> a downstream device wakes up it correctly causes the OHCI controller
> to come out of suspend.

Just to let you know, this patch turns out to not be quite right:
 * if the port is suspended and the controller is not, we need to
   raise OHCI_INTR_RHSC
 * if the controller is suspended we need to put it into the
   resume state
 * the controller can be suspended when the port is not, so the
   check on s->ctl musn't be inside the port->ctrl if().

Sorry for the half-baked patch. I'll send a fixed version shortly.

-- PMM