[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] get_maintainer: update to match qemu tree
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] get_maintainer: update to match qemu tree |
Date: |
Wed, 15 Jun 2011 22:01:10 +0300 |
On Tue, Jun 14, 2011 at 8:38 PM, Michael S. Tsirkin <address@hidden> wrote:
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> scripts/get_maintainer.pl | 29 +++++++----------------------
> 1 files changed, 7 insertions(+), 22 deletions(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index d29a8d7..c52ae59 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -258,9 +258,9 @@ if ($email &&
> die "$P: Please select at least 1 email option\n";
> }
>
> -if (!top_of_kernel_tree($lk_path)) {
> +if (!top_of_tree($lk_path)) {
> die "$P: The current directory does not appear to be "
> - . "a linux kernel source tree.\n";
> + . "a qemu source tree.\n";
QEMU
> }
>
> ## Read MAINTAINERS for type/value pairs
> @@ -792,7 +792,7 @@ Notes:
> --git-min-signatures, --git-max-maintainers, --git-min-percent, and
> --git-blame
> Use --hg-since not --git-since to control date selection
> - File ".get_maintainer.conf", if it exists in the linux kernel source root
> + File ".get_maintainer.conf", if it exists in the qemu source root
QEMU
> directory, can change whatever get_maintainer defaults are desired.
> Entries in this file can be any command line argument.
> This file is prepended to any additional command line arguments.
> @@ -800,28 +800,13 @@ Notes:
> EOT
> }
>
> -sub top_of_kernel_tree {
> +sub top_of_tree {
> my ($lk_path) = @_;
>
> if ($lk_path ne "" && substr($lk_path,length($lk_path)-1,1) ne "/") {
> $lk_path .= "/";
> }
> - if ( (-f "${lk_path}COPYING")
> - && (-f "${lk_path}CREDITS")
> - && (-f "${lk_path}Kbuild")
> - && (-f "${lk_path}MAINTAINERS")
> - && (-f "${lk_path}Makefile")
> - && (-f "${lk_path}README")
> - && (-d "${lk_path}Documentation")
> - && (-d "${lk_path}arch")
> - && (-d "${lk_path}include")
> - && (-d "${lk_path}drivers")
> - && (-d "${lk_path}fs")
> - && (-d "${lk_path}init")
> - && (-d "${lk_path}ipc")
> - && (-d "${lk_path}kernel")
> - && (-d "${lk_path}lib")
> - && (-d "${lk_path}scripts")) {
> + if (-f "${lk_path}MAINTAINERS") {
The similar check in scripts/checkpatch.pl uses "COPYING",
"MAINTAINERS", "Makefile", "README", "docs", "VERSION", and "vl.c".
Please match that.
> return 1;
> }
> return 0;
> @@ -1387,8 +1372,8 @@ sub vcs_exists {
> if (!$printed_novcs) {
> warn("$P: No supported VCS found. Add --nogit to options?\n");
> warn("Using a git repository produces better results.\n");
> - warn("Try Linus Torvalds' latest git repository using:\n");
> - warn("git clone
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git\n");
> + warn("Try latest git repository using:\n");
> + warn("git clone git://git.qemu.org/qemu.git\n");
> $printed_novcs = 1;
> }
> return 0;
> --
> 1.7.5.53.gc233e
>
>