qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC][PATCH] Register Linux dyntick timer as per-thread


From: Jan Kiszka
Subject: Re: [Qemu-devel] [RFC][PATCH] Register Linux dyntick timer as per-thread signal
Date: Fri, 17 Jun 2011 11:25:23 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2011-06-16 17:24, Alexandre Raymond wrote:
> Hi Jan,
> 
> On Thu, Jun 16, 2011 at 5:31 AM, Jan Kiszka <address@hidden> wrote:
>> Ingo Molnar pointed out that sending the timer signal to the whole
>> process, just blocking it everywhere, is suboptimal with an increasing
>> number of threads. QEMU is using this pattern so far.
> 
> I am not familiar with this code, but don't you already need to block
> SIGALRM properly in all threads for OSes != Linux ? If so, isn't this
> patch redundant?

Yes, we still need to block for the sake of non-Linux UNIX or
pre-signalfd Linux. That blocking becomes in fact redundant in the
signalfd case, but that's both harmless and not worth optimizing. The
key is that per-thread signals do not care about other threads having
them blocked or not, they only deal with the target thread.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux



reply via email to

[Prev in Thread] Current Thread [Next in Thread]