[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/14] exec: last_first_tb was only used in !ONL
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 09/14] exec: last_first_tb was only used in !ONLY_USER case |
Date: |
Fri, 17 Jun 2011 12:38:30 +0100 |
On 2 June 2011 12:53, Juan Quintela <address@hidden> wrote:
> Once there, use a better variable name.
>
> Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
> ---
> exec.c | 10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 8529390..4b1afec 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1208,12 +1208,16 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> unsigned int n, tb_page_addr_t page_addr)
> {
> PageDesc *p;
> - TranslationBlock *last_first_tb;
> +#ifndef CONFIG_USER_ONLY
> + bool page_already_protected;
> +#endif
>
> tb->page_addr[n] = page_addr;
> p = page_find_alloc(page_addr >> TARGET_PAGE_BITS, 1);
> tb->page_next[n] = p->first_tb;
> - last_first_tb = p->first_tb;
> +#ifndef CONFIG_USER_ONLY
> + page_already_protected = p->first_tb != NULL;
> +#endif
> p->first_tb = (TranslationBlock *)((long)tb | n);
> invalidate_page_bitmap(p);
>
> @@ -1249,7 +1253,7 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> /* if some code is already present, then the pages are already
> protected. So we handle the case where only the first TB is
> allocated in a physical page */
> - if (!last_first_tb) {
> + if (!page_already_protected) {
> tlb_protect_code(page_addr);
> }
> #endif
> --
> 1.7.5.2
>
>
>
--
12345678901234567890123456789012345678901234567890123456789012345678901234567890
1 2 3 4 5 6 7 8
- [Qemu-devel] [PATCH 04/14] xen: pentry is not used in this function, (continued)
- [Qemu-devel] [PATCH 04/14] xen: pentry is not used in this function, Juan Quintela, 2011/06/02
- [Qemu-devel] [PATCH 03/14] flatload: memp was a write-only variable, Juan Quintela, 2011/06/02
- [Qemu-devel] [PATCH 06/14] flatload: end_code was only used in a debug message, Juan Quintela, 2011/06/02
- [Qemu-devel] [PATCH 05/14] linuxload: id_change was a write only variable, Juan Quintela, 2011/06/02
- [Qemu-devel] [PATCH 07/14] alpha: fn2 was a write only variable, Juan Quintela, 2011/06/02
- [Qemu-devel] [PATCH 08/14] syscall: really return ret code, Juan Quintela, 2011/06/02
- [Qemu-devel] [PATCH 09/14] exec: last_first_tb was only used in !ONLY_USER case, Juan Quintela, 2011/06/02
- [Qemu-devel] [PATCH 11/14] linux-user: fpu_save_addr is not used, Juan Quintela, 2011/06/02
- [Qemu-devel] [PATCH 12/14] linux-user: syscall should use sanitized arg1, Juan Quintela, 2011/06/02
- [Qemu-devel] [PATCH 14/14] lsi53c895a: current_dev is not used, Juan Quintela, 2011/06/02
- [Qemu-devel] [PATCH 13/14] alpha: disp12 is not used for USER emulation, Juan Quintela, 2011/06/02