qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Optimize screendump


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH] Optimize screendump
Date: Sun, 19 Jun 2011 19:00:08 +0200

On 19.06.2011, at 18:04, Avi Kivity wrote:

> On 06/19/2011 06:53 PM, Andreas Färber wrote:
>> Am 19.06.2011 um 17:46 schrieb Avi Kivity:
>> 
>>> On 06/19/2011 06:22 PM, Stefan Hajnoczi wrote:
>>>> I wonder if this will break non-Linux platforms.  Perhaps buffer an
>>>> entire row of pixels instead and only fwrite(3) at the end of the
>>>> outer loop.
>>> 
>>> That's how I wrote this in the first place.  Since the consensus is against 
>>> these functions, I'll submit that version instead.
>> 
>> Maybe add a qemu_fputc_unlocked() and do a configure check for it?
> 
> Good idea.  I'll try that, unless people disagree.

Writing by row should be faster and pretty straight forward, no?


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]