[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] configure: Don't create symlinks to nonexist
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3] configure: Don't create symlinks to nonexistent targets |
Date: |
Wed, 22 Jun 2011 13:28:49 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jun 03, 2011 at 05:10:40PM +0100, Peter Maydell wrote:
> When we create the symlinks to source tree files, don't create them
> if the file is not actually present in the source tree; this will
> happen if the file is in a git submodule that wasn't checked out.
>
> This also avoids the odd effect where an in-source-tree configure
> will end up creating the missing file as a symlink to itself.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> v1->v2: remove debug printing
> v2->v3: don't use test constructs marked by POSIX as obsolete,
> as pointed out by Paolo Bonzini
>
> configure | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
Tested here and you've addressed review comments.
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan